Wide benchmark support - Githubissues

bitshifter / mathbench-rs

Comparing performance of Rust math libraries for common 3D game and graphics tasks

Other

197 stars 16 forks source link

Wide benchmark support #24

Closed fu5ha closed 4 years ago

fu5ha commented 4 years ago

Add a full set of 'wide' benchmarks
Add new ray-sphere intersection benchmark
Add more ultraviolet benches and tests

Note that I haven't tried the modifications I made to the summary script because I don't have a python env setup on my main machine atm.

bitshifter commented 4 years ago

Awesome, thanks for doing all of that! I will have a read through over the weekend. I can look at the summary script.

bitshifter commented 4 years ago

Just realised I'd made a bunch of comments yesterday but forgot to hit the start review button...

bitshifter commented 4 years ago

How are you getting on with this @termhn ? I realize you've already put a heap of work into this, so I could always merge it over into a branch and address the remaining PR issues myself if you'd prefer.

fu5ha commented 4 years ago

@bitshifter Been a bit busy but I should be able to get around to fixing these up soon (maybe today, not sure)

fu5ha commented 4 years ago

Alright, @bitshifter I think this is ready for further review :) I think I addressed most of the points, and also rebased on master.

bitshifter commented 4 years ago

Awesome, thank you. I will take a look soon.

bitshifter commented 4 years ago

Thanks again. There's a few small issues but I can sort them out.