search

bitshifter / mathbench-rs

Comparing performance of Rust math libraries for common 3D game and graphics tasks
Other
197 stars 16 forks source link

no bench target named `benchmark` #33

Closed Ajghumaliya closed 1 year ago

Ajghumaliya commented 1 year ago

In after-suucess.sh file there is mention "cargo bench --bench benchmark " but benchmark file in not contain in bench folder so it will show error if use this code in CI pipeline

bitshifter commented 1 year ago

I think this was just very old and unused, but it looks like you've fixed it with your changes.

Probably the way to go for benching on CI would be to use https://bheisler.github.io/criterion.rs/book/iai/iai.html which I'm not currently doing here anyway.