Dependencies should use an exact patch version

bitshifter / mathbench-rs

Comparing performance of Rust math libraries for common 3D game and graphics tasks

Other

197 stars 16 forks source link

Dependencies should use an exact patch version #8

Closed Lokathor closed 5 years ago

Lokathor commented 5 years ago

Since a lib can update its internal formulas for better speed in just a patch release, all dependencies should be listed down to the patch level and benchmark presentations should list the exact version used to run the benchmarks.

bitshifter commented 5 years ago

Makes sense. I'm on vacation right now but if you want to make a PR I can merge it. Probably best to use the versions mentioned in the results in the readme if you do.

Lokathor commented 5 years ago

I'm working on adding enough to Hektor to get it into the benchmarks, so I'll include patch numbers in that PR if you don't have it set by then.

bitshifter commented 5 years ago

You might want to do that against the euclid branch. It's pretty much done, I just need to update the readme before merging to master

bitshifter commented 5 years ago

I've made this change on master now.