search

bitsofinfo / hazelcast-docker-swarm-discovery-spi

Docker Swarm based discovery strategy SPI for Hazelcast enabled applications
Apache License 2.0
39 stars 33 forks source link

issue_36_serviceCriteria Constrain explicitly on dockerServiceName the results from criteria-based /services request #37

Closed robinroos closed 5 years ago

robinroos commented 5 years ago

Define ServiceFilter package, interface and hierarchy Use ServiceFilter to constrain explicitly on dockerServiceName the results from criteria-based /services request Reduce level of some log outputs from INFO to FINE

robinroos commented 5 years ago

Commits are in to remedy the issues you raised. PR build is underway.

For the service/spec null check I chose try/catch in order to retain fluency.

robinroos commented 5 years ago

PR build is green.

bitsofinfo commented 5 years ago

Thanks!

bitsofinfo commented 5 years ago

@robinroos also see https://github.com/bitsofinfo/hazelcast-docker-swarm-discovery-spi/issues/39 one other item is needed on this please