Five refactorings - Githubissues

bitsofinfo / hazelcast-docker-swarm-discovery-spi

Docker Swarm based discovery strategy SPI for Hazelcast enabled applications

Apache License 2.0

39 stars 33 forks source link

Five refactorings #45

Open robinroos opened 5 years ago

robinroos commented 5 years ago

Five refactorings:

”throws" declarations should not be superfluous
Static fields should not be updated in constructors (in this case the fields should not be static)
Unused "private" fields should be removed
Optimize Imports
Standard outputs should not be used directly to log anything (in this case suppress the warning since logging "to stdout" is the express purpose of the class SystemPrintLogger)

robinroos commented 5 years ago

The next set of refactorings is ready.

bitsofinfo commented 5 years ago

Please just proceed with adding whatever other commits you have or are proposing to this PR if possible no need for a a bunch of different PRs if they are all just little things like this that are being dumped out of some automated code analyzer tool. thx