search

bitsongofficial / go-bitsong

:rocket: Official BitSong Blockchain Implementation in Go
Other
78 stars 68 forks source link

Query NFTs by Authority #165

Closed giorgionocera closed 4 months ago

giorgionocera commented 2 years ago

In the nft module it could be useful to query the nfts by authority, similarly to how it could be done with the collections. Moreover, it could be useful to paginate the results (since they can become a large number).

Do you agree?

ryusmo commented 2 years ago

Yea, I agree on adding paginations for queries. I think we already have querying nfts by owner. bitsongd query nft nfts-by-owner [owner]

giorgionocera commented 2 years ago

Nice! With respect to the owner and authority they are different attributes. So we could think to add the authority (which is who has the ability to modify the metadata) query. What do you think about it?

angelorc commented 2 years ago

The pagination is already integrated in the grpc query, howver I think we should set a new index on the store

angelorc commented 2 years ago

This feature could be handled by an offchain indexer (for example subquery network).