search

bitsongofficial / radio-player

A simple Radio UI Player by bitsong
Other
0 stars 1 forks source link

Implementing externals links for radio #6

Open eti88 opened 3 years ago

eti88 commented 3 years ago

Description

Currently the endpoint of the radio not returning any information of the social accounts

What is the expected behavior?

The endpoint must return also the array of socials something like: [ {. name: 'facebook', link:'#' }, {. name: 'twitter', link:'#' }, ... ]

angelorc commented 3 years ago

This can be done by implementing the structure in our api endpoint. The structure will be the following

externals: [
  { website: 'https://....' },
  { facebook: 'https://....' },
  { twitter: 'https://....' },
....
]

Do you prefer something like above (key, value) or something more specific?

eti88 commented 3 years ago

This implementation is fine but with this logic you must remove the contact (i guess used for email address) and website properties.

angelorc commented 3 years ago

contact? what you mean I don't remember the endpoint

eti88 commented 3 years ago

Check this endpoint: https://api.play.bitsong.io/api/v1/radio