bitsongofficial / sinfonia-ui

https://sinfonia-ui.vercel.app
6 stars 11 forks source link

Disable swap #392

Closed giorgionocera closed 2 years ago

giorgionocera commented 2 years ago

@giannnni and @DavideSegullo , what do you think about disabling the swap button, after clicking on the swap button to perform a swap tx, until the transaction is completed?

Reference:

giannnni commented 2 years ago

Correct. I'm agree

giorgionocera commented 2 years ago

Thank you for your feedback @giannnni. @DavideSegullo let's move to development!

giorgionocera commented 2 years ago

With this edit, we disable the swap button when any tx is pending. But IMHO, if we want to follow the pattern "disable if something is pending", we should do it with any button that could generate a tx (e.g., claim buttons, add liquidity buttons, etc.). Otherways, we can disable the swap button only if a swap tx is pending.

@giannnni and @DavideSegullo, what do you think about this?

DavideSegullo commented 2 years ago

Uhm maybe we should disable every buttons if something is in pending, what do you think?

giorgionocera commented 2 years ago

I think that together with the implementation linked to issue #405, it could be perfect to disable every button. Let's do it!! 😄

giorgionocera commented 2 years ago

Thank you! 😄