bitsongofficial / sinfonia-ui

6 stars 12 forks source link

Add notifications #405

Closed giorgionocera closed 1 year ago

giorgionocera commented 1 year ago

As per the meeting with @angelorc, we are removing the transactions list from the swap page (as said in issue #386). In this sense, we can think of a new approach with a notification system for the user, where we can also show the transactions as notifications.

giannnni commented 1 year ago

As discussed in previous meetings, I suggest a simple notification icon on the right top of the page, opening a dropdown when clicked.

Schermata 2022-07-22 alle 15 48 19

The icon changes when a transaction is processing, showing the same spinner we use in toast notification. This until the Tx is validated, allowing user to monitor status of Txs from every page without opening the component.

Schermata 2022-07-22 alle 15 46 42
giorgionocera commented 1 year ago

It is very nice 😍 ! @giannnni, do we also have the tablet and mobile design for the component? What is the behavior for no notification available? Is the symbol disabled? What?

Moreover, @DavideSegullo we can make the text clickable for referring to the tx on mintscan!

giorgionocera commented 1 year ago

@DavideSegullo, maybe it could be useful to also give a look at issue #96.

DavideSegullo commented 1 year ago

Ok, I'll remove the old notifications system, the one that appears at the top center, do you agree with me @Giorgionocera @giannnni ?

DavideSegullo commented 1 year ago

I removed the old notification system, I chose to keep the success and error messages anyway, what do you think? @Giorgionocera @giannnni

giorgionocera commented 1 year ago

I'd like to listen to @giannnni feedback, even if I like the solution you proposed.

giannnni commented 1 year ago

Yes I like it @DavideSegullo and as I said in our last call you could go to the bar and ask for an Ham&Cheese Toast Notification if missing.

giorgionocera commented 1 year ago

At the moment only the swap actions are tracked as notifications. IMHO we should trace all other actions:

@giannnni, @DavideSegullo, and @giulioaiello please, give me feedback ASAP (in case you agree, please, @giulioaiello you need to provide us with the corresponding texts).

DavideSegullo commented 1 year ago

@Giorgionocera Just some notes, with "lock x tokens" and "unlock x tokens" do you mean GAMM?

We can also add the airdrop ID or name for "Claim an airdrop" and change it likes "you redeemed foo airdrop"

giorgionocera commented 1 year ago

@Giorgionocera Just some notes, with "lock x tokens" and "unlock x tokens" do you mean GAMM? We can also add the airdrop ID or name for "Claim an airdrop" and change it likes "you redeemed foo airdrop"

You got it!

giorgionocera commented 1 year ago

Perfect! Thank you!