bitstadium / HockeySDK-Cordova

HockeyApp was retired and the SDKs are deprecated. Please use App Center instead.
https://github.com/microsoft/appcenter-sdk-cordova
Other
82 stars 73 forks source link

Upgrade the plugin.xml to the cordova-android@7.0.0 project structure #96

Closed eugenpodaru closed 6 years ago

eugenpodaru commented 6 years ago

As announced here, with the release of cordova-android@7.0.0 the project structure has changed. This means that the plugin is not compatible anymore due to the config-file statements in the plugin.xml that point to file paths that have been changed.

I updated the plugin.xml for android as advised in the documentation and increased the version of the cordova-android dependency, since the plugin won't be backwards compatible. A solution to preserve backwards compatibility might be to use wildcards in the config-file target paths, but I have not tried that.

msftclas commented 6 years ago

CLA assistant check
All CLA requirements met.

ElektrojungeAtWork commented 6 years ago

Hey @eugenpodaru,

thx for this!!!

Stay tuned for a release soon.

Best, Benjamin

eugenpodaru commented 6 years ago

@TroubleMakerBen I have checked the config-file implementation and it seems like there is a fix for android to check the new paths, if the default paths don't exist. So actually no action is required from your side.

But there is still a problem. Adding the plugin to the project works, but the build fails. What I discovered is that resource-file is now putting the HockeySDK-5.0.4.aar lib in app/src/main/libs while gradle is looking into app/libs. One option would be to change the gradle script and another would be to use lib-file instead of resource-file, which puts the lib into app/libs. You can check the implementation for both lib-file and resource-file here.

bmourat commented 6 years ago

@eugenpodaru there is already a fix for lib file location, see #95

eugenpodaru commented 6 years ago

@bmourat Great, then I will be waiting for the release.

@TroubleMakerBen I guess you can close this pull request, since it's not needed.