bitstadium / HockeySDK-iOS

HockeyApp was retired and the SDKs are deprecated. Please use App Center instead.
https://github.com/microsoft/appcenter-sdk-apple
Other
597 stars 268 forks source link

Headers are marked as private - causes issues when integrating the SDK as sources #309

Closed blach closed 8 years ago

blach commented 8 years ago

The files BITHockeyLoggerPrivate.h and BITChannelPrivate.h are marked as private in the Xcode project.

When archiving my app, these header files are put into the "Private Headers Folder Path" which by default is /usr/local/include.

The headers should be marked as "Project", not "Private". "Private" headers are exported to the build product.

bildschirmfoto 2016-07-06 um 21 47 31

Here is how that looks in my app archive:

bildschirmfoto 2016-07-06 um 21 50 47

Xcode doesn't recognize the archive as an iOS app, so I cannot upload it to the App Store.

If I change the header to "Project", everything works as expected.

lumaxis commented 8 years ago

Thanks for catching this!