search

bitstadium / HockeySDK-iOS

HockeyApp was retired and the SDKs are deprecated. Please use App Center instead.
https://github.com/microsoft/appcenter-sdk-apple
Other
597 stars 268 forks source link

Xcode8 and Swift3 #330

Closed tcurdt closed 8 years ago

tcurdt commented 8 years ago

A release would be great. Is this the Xcode8 branch?

nheagy commented 8 years ago

I think this is pure Obj-C, in which case specific Swift 3 support isn't necessary.

tcurdt commented 8 years ago

Probably true - yet the building the latest release with carthage gives:

$ carthage update --platform iOS
*** Fetching HockeySDK-iOS
*** Downloading HockeySDK-iOS.framework binary at "4.1.0"
*** Checking out HockeySDK-iOS at "4.1.0"
*** xcodebuild output can be found in /var/folders/pf/7vhqx5bn41qddypw08w9jc4w0000gn/T/carthage-xcodebuild.UHTCQx.log
*** Building scheme "HockeySDK Framework" in HockeySDK.xcodeproj

The following commands produced analyzer issues:
  AnalyzeShallow /path/to/project/Carthage/Checkouts/HockeySDK-iOS/Classes/BITFeedbackListViewController.m
  AnalyzeShallow /path/to/project/Carthage/Checkouts/HockeySDK-iOS/Classes/BITUpdateViewController.m
  AnalyzeShallow HockeySDKTests/BITChannelTests.m
(3 commands with analyzer issues)

The following commands produced analyzer issues:
  AnalyzeShallow /path/to/project/Carthage/Checkouts/HockeySDK-iOS/Classes/BITFeedbackListViewController.m
  AnalyzeShallow /path/to/project/Carthage/Checkouts/HockeySDK-iOS/Classes/BITUpdateViewController.m
  AnalyzeShallow HockeySDKTests/BITChannelTests.m
(3 commands with analyzer issues)
/path/to/project/Carthage/Checkouts/HockeySDK-iOS/Classes/BITFeedbackListViewController.m:1014:3: warning: Null is returned from a method that is expected to return a non-null value
/path/to/project/Carthage/Checkouts/HockeySDK-iOS/Classes/BITUpdateViewController.m:499:3: warning: Null is returned from a method that is expected to return a non-null value
/path/to/project/Carthage/Checkouts/HockeySDK-iOS/Support/HockeySDKTests/BITChannelTests.m:31:27: warning: Null is assigned to a pointer which is expected to have non-null value
warning: /var/folders/g9/mxr37xcs33g38q39zkf76xb00000gp/C/com.apple.DeveloperTools/7.2-7C68/Xcode/SharedPrecompiledHeaders/OCMockLib-Prefix-aguhwhqcwfsriffwgjqlwwuendhr/OCMockLib-Prefix.pch.pch: No such file or directory
warning: /var/folders/g9/mxr37xcs33g38q39zkf76xb00000gp/C/com.apple.DeveloperTools/7.2-7C68/Xcode/SharedPrecompiledHeaders/OCMockLib-Prefix-efhbsnkhmearojbasgiitukrjnoo/OCMockLib-Prefix.pch.pch: No such file or directory
/path/to/project/Carthage/Checkouts/HockeySDK-iOS/Classes/BITFeedbackListViewController.m:1014:3: warning: Null is returned from a method that is expected to return a non-null value
/path/to/project/Carthage/Checkouts/HockeySDK-iOS/Classes/BITUpdateViewController.m:499:3: warning: Null is returned from a method that is expected to return a non-null value
/path/to/project/Carthage/Checkouts/HockeySDK-iOS/Support/HockeySDKTests/BITChannelTests.m:31:27: warning: Null is assigned to a pointer which is expected to have non-null value
warning: /var/folders/g9/mxr37xcs33g38q39zkf76xb00000gp/C/com.apple.DeveloperTools/7.2-7C68/Xcode/SharedPrecompiledHeaders/OCMockLib-Prefix-efeadqrgtnidxwbadwtohuxejrdb/OCMockLib-Prefix.pch.pch: No such file or directory
warning: /var/folders/g9/mxr37xcs33g38q39zkf76xb00000gp/C/com.apple.DeveloperTools/7.2-7C68/Xcode/SharedPrecompiledHeaders/OCMockLib-Prefix-bxixbexkmoooetbthjtvimnkelbz/OCMockLib-Prefix.pch.pch: No such file or directory

The develop branch gives:

*** Fetching HockeySDK-iOS
*** Checking out HockeySDK-iOS at "98bae5c30c947afc56ed98f070845993cf23f1b0"
*** xcodebuild output can be found in /var/folders/pf/7vhqx5bn41qddypw08w9jc4w0000gn/T/carthage-xcodebuild.lFyoV9.log
*** Building scheme "HockeySDK Framework" in HockeySDK.xcodeproj

The following commands produced analyzer issues:
  AnalyzeShallow /project/Carthage/Checkouts/HockeySDK-iOS/Classes/BITFeedbackListViewController.m
  AnalyzeShallow /project/Carthage/Checkouts/HockeySDK-iOS/Classes/BITUpdateViewController.m
  AnalyzeShallow HockeySDKTests/BITChannelTests.m
(3 commands with analyzer issues)

The following commands produced analyzer issues:
  AnalyzeShallow /project/Carthage/Checkouts/HockeySDK-iOS/Classes/BITFeedbackListViewController.m
  AnalyzeShallow /project/Carthage/Checkouts/HockeySDK-iOS/Classes/BITUpdateViewController.m
  AnalyzeShallow HockeySDKTests/BITChannelTests.m
(3 commands with analyzer issues)
/project/Carthage/Checkouts/HockeySDK-iOS/Classes/BITAttributedLabel.m:1155:10: warning: address of 'NSLinkAttributeName' will always evaluate to 'true' [-Wpointer-bool-conversion]
/project/Carthage/Checkouts/HockeySDK-iOS/Classes/BITAttributedLabel.m:1155:10: warning: address of 'NSLinkAttributeName' will always evaluate to 'true' [-Wpointer-bool-conversion]
/project/Carthage/Checkouts/HockeySDK-iOS/Classes/BITAttributedLabel.m:1155:10: warning: address of 'NSLinkAttributeName' will always evaluate to 'true' [-Wpointer-bool-conversion]
/project/Carthage/Checkouts/HockeySDK-iOS/Classes/BITFeedbackListViewController.m:1014:3: warning: Null is returned from a method that is expected to return a non-null value
/project/Carthage/Checkouts/HockeySDK-iOS/Classes/BITUpdateViewController.m:499:3: warning: Null is returned from a method that is expected to return a non-null value
/project/Carthage/Checkouts/HockeySDK-iOS/Support/HockeySDKTests/BITChannelTests.m:31:27: warning: Null is assigned to a pointer which is expected to have non-null value
warning: /var/folders/g9/mxr37xcs33g38q39zkf76xb00000gp/C/com.apple.DeveloperTools/7.2-7C68/Xcode/SharedPrecompiledHeaders/OCMockLib-Prefix-aguhwhqcwfsriffwgjqlwwuendhr/OCMockLib-Prefix.pch.pch: No such file or directory
warning: /var/folders/g9/mxr37xcs33g38q39zkf76xb00000gp/C/com.apple.DeveloperTools/7.2-7C68/Xcode/SharedPrecompiledHeaders/OCMockLib-Prefix-efhbsnkhmearojbasgiitukrjnoo/OCMockLib-Prefix.pch.pch: No such file or directory
/project/Carthage/Checkouts/HockeySDK-iOS/Classes/BITAttributedLabel.m:1155:10: warning: address of 'NSLinkAttributeName' will always evaluate to 'true' [-Wpointer-bool-conversion]
/project/Carthage/Checkouts/HockeySDK-iOS/Classes/BITAttributedLabel.m:1155:10: warning: address of 'NSLinkAttributeName' will always evaluate to 'true' [-Wpointer-bool-conversion]
/project/Carthage/Checkouts/HockeySDK-iOS/Classes/BITFeedbackListViewController.m:1014:3: warning: Null is returned from a method that is expected to return a non-null value
/project/Carthage/Checkouts/HockeySDK-iOS/Classes/BITUpdateViewController.m:499:3: warning: Null is returned from a method that is expected to return a non-null value
/project/Carthage/Checkouts/HockeySDK-iOS/Support/HockeySDKTests/BITChannelTests.m:31:27: warning: Null is assigned to a pointer which is expected to have non-null value
warning: /var/folders/g9/mxr37xcs33g38q39zkf76xb00000gp/C/com.apple.DeveloperTools/7.2-7C68/Xcode/SharedPrecompiledHeaders/OCMockLib-Prefix-efeadqrgtnidxwbadwtohuxejrdb/OCMockLib-Prefix.pch.pch: No such file or directory
warning: /var/folders/g9/mxr37xcs33g38q39zkf76xb00000gp/C/com.apple.DeveloperTools/7.2-7C68/Xcode/SharedPrecompiledHeaders/OCMockLib-Prefix-bxixbexkmoooetbthjtvimnkelbz/OCMockLib-Prefix.pch.pch: No such file or directory

and master gives

*** Fetching HockeySDK-iOS
*** Checking out HockeySDK-iOS at "c0813757c3dcd3e4adea09ec8b9f6e168805a162"
*** xcodebuild output can be found in /var/folders/pf/7vhqx5bn41qddypw08w9jc4w0000gn/T/carthage-xcodebuild.Zk8w7x.log
*** Building scheme "HockeySDK Framework" in HockeySDK.xcodeproj

The following commands produced analyzer issues:
  AnalyzeShallow /project/Carthage/Checkouts/HockeySDK-iOS/Classes/BITFeedbackListViewController.m
  AnalyzeShallow /project/Carthage/Checkouts/HockeySDK-iOS/Classes/BITUpdateViewController.m
  AnalyzeShallow HockeySDKTests/BITChannelTests.m
(3 commands with analyzer issues)

The following commands produced analyzer issues:
  AnalyzeShallow /project/Carthage/Checkouts/HockeySDK-iOS/Classes/BITFeedbackListViewController.m
  AnalyzeShallow /project/Carthage/Checkouts/HockeySDK-iOS/Classes/BITUpdateViewController.m
  AnalyzeShallow HockeySDKTests/BITChannelTests.m
(3 commands with analyzer issues)
/project/Carthage/Checkouts/HockeySDK-iOS/Classes/BITFeedbackListViewController.m:1014:3: warning: Null is returned from a method that is expected to return a non-null value
/project/Carthage/Checkouts/HockeySDK-iOS/Classes/BITUpdateViewController.m:499:3: warning: Null is returned from a method that is expected to return a non-null value
/project/Carthage/Checkouts/HockeySDK-iOS/Support/HockeySDKTests/BITChannelTests.m:31:27: warning: Null is assigned to a pointer which is expected to have non-null value
warning: /var/folders/g9/mxr37xcs33g38q39zkf76xb00000gp/C/com.apple.DeveloperTools/7.2-7C68/Xcode/SharedPrecompiledHeaders/OCMockLib-Prefix-aguhwhqcwfsriffwgjqlwwuendhr/OCMockLib-Prefix.pch.pch: No such file or directory
warning: /var/folders/g9/mxr37xcs33g38q39zkf76xb00000gp/C/com.apple.DeveloperTools/7.2-7C68/Xcode/SharedPrecompiledHeaders/OCMockLib-Prefix-efhbsnkhmearojbasgiitukrjnoo/OCMockLib-Prefix.pch.pch: No such file or directory
/project/Carthage/Checkouts/HockeySDK-iOS/Classes/BITFeedbackListViewController.m:1014:3: warning: Null is returned from a method that is expected to return a non-null value
/project/Carthage/Checkouts/HockeySDK-iOS/Classes/BITUpdateViewController.m:499:3: warning: Null is returned from a method that is expected to return a non-null value
/project/Carthage/Checkouts/HockeySDK-iOS/Support/HockeySDKTests/BITChannelTests.m:31:27: warning: Null is assigned to a pointer which is expected to have non-null value
warning: /var/folders/g9/mxr37xcs33g38q39zkf76xb00000gp/C/com.apple.DeveloperTools/7.2-7C68/Xcode/SharedPrecompiledHeaders/OCMockLib-Prefix-efeadqrgtnidxwbadwtohuxejrdb/OCMockLib-Prefix.pch.pch: No such file or directory
warning: /var/folders/g9/mxr37xcs33g38q39zkf76xb00000gp/C/com.apple.DeveloperTools/7.2-7C68/Xcode/SharedPrecompiledHeaders/OCMockLib-Prefix-bxixbexkmoooetbthjtvimnkelbz/OCMockLib-Prefix.pch.pch: No such file or directory
ElektrojungeAtWork commented 8 years ago

Hey guys, We're working all hands on HockeySDK-iOS 4.1.1. Our original plan was to release 4.1.1 yesterday, but were caught off-guard by the issue mentioned at the top of the Readme in our master branch so we need to fix that before releasing 4.1.1. Sorry for any inconvenience this causes for you. 🖖 Benny

tcurdt commented 8 years ago

Hey Benny, thanks for working on this. Any news on when 4.1.1 will be ready?

ElektrojungeAtWork commented 8 years ago

Hey y'all!

Thanks for your patience everyone. We just version 4.1.1. Make sure to read the official blogpost and have a look at the readme, especially if you are using our Feedback feature.

Let us know in case you run into issues (here, or via Support) and thanks for using HockeyApp in the first place. =)