bitstadium / HockeySDK-iOS

HockeyApp was retired and the SDKs are deprecated. Please use App Center instead.
https://github.com/microsoft/appcenter-sdk-apple
Other
597 stars 268 forks source link

Force New Feedback thread #359

Closed tabuchid closed 7 years ago

tabuchid commented 8 years ago

Adds a configuration to allow for a new thread to be generated for each feedback item. This is useful in scenarios where feedback is used more for bug reporting and feature requests then as a user communication tool.

msftclas commented 8 years ago

Hi @tabuchid, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

msftclas commented 8 years ago

@tabuchid, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, MSBOT;

ijdoc commented 7 years ago

@tabuchid is there a way to achieve this without modifying the SDK? I achieved something similar on Android using the SDK's public methods and I want to know if this is possible on iOS as well so I can incorporate it into my work without breaking compatibility with the SDK (if the pull request is not accepted)

tabuchid commented 7 years ago

@jorgesilva I haven't found a way to do this w/o modifying the SDK. One of my colleagues added the feature to Android as well https://github.com/bitstadium/HockeySDK-Android/pull/189 From my understanding the HockeyTeam hasn't merged this because it hasn't been implemented on all platforms but with Android and iOS being done that only leaves Xamarin so if you know any Xamarin engineers that could pick it up we potentially can get this merged.

tivadartimea commented 7 years ago

Hi @tabuchid, I'm working with @jorgesilva. I worked before with Xamarin, could you tell me what should I do? Maybe I can help.

matthiaswenz commented 7 years ago

Hi @tabuchid, thanks for the PR. We're looking at this and will be discussing this internally.

tabuchid commented 7 years ago

@tivadartimea Sorry for the late reply. The changes are pretty straightforward. This PR and https://github.com/bitstadium/HockeySDK-Android/pull/189 add a flag called forceNewThread which just ensure the feedback thread token is nil when feedback is sent. This causes hockey to generate a new thread for that piece of feedback. It'd be awesome if you can get this to work for Xamarin cause then we'll have it implemented in all three environments which is what I was told was one of the blockers for merging this.

ElektrojungeAtWork commented 7 years ago

Hey guys,

We've scheduled a release within the first half of december which will include this.

tabuchid commented 7 years ago

@TroubleMakerBen 🎉! Thank you!

ijdoc commented 7 years ago

🤗