search

bitstadium / HockeySDK-iOS

HockeyApp was retired and the SDKs are deprecated. Please use App Center instead.
https://github.com/microsoft/appcenter-sdk-apple
Other
597 stars 268 forks source link

Added support for logging exceptions #377

Closed raylillywhite closed 7 years ago

raylillywhite commented 7 years ago

This uses the plcrashreporter methods that were added in the last year or so in order to support logging an exception and stacktrace without crashing.

msftclas commented 7 years ago

Hi @raylillywhite, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

ElektrojungeAtWork commented 7 years ago

Hey Ray!

Thanks for adding this API something like this has been on our backlog for a while. The SDK team is already winding down for the holidays fly to Germany or wherever to meet family and get some rest. We will discuss this next year and I will let you know here. The reason why we need some more discussion on this is that we need to look at the big picture and what we want to do on the other platforms. Stay tuned and again, thanks for the contribution. It's much appreciated.

🖖 Benny

msftgits commented 7 years ago

Hi, I am closing and re-opening this PR to bump the CLA bot. Sorry for the inconvenience!

msftclas commented 7 years ago

Hi @raylillywhite, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! You've already signed the contribution license agreement. Thanks! We will now validate the agreement and then real humans will evaluate your PR.

TTYL, MSBOT;

ghost commented 7 years ago

Hi there,

I am sorry but we can't support that in HockeyApp and therefor can not accept this pull request. The backend has a limit of accepting 60 requests per minute, which means per app and day you can receive a maximum of ~86400 crash reports. Handled Errors are send much more often and you will get less crash reports if you would do that. Also the backend and UI doesn't support to view only crashes or handled errors, and the handled errors on top will impact the values for crash free users because of that.

We do plan to support this in the next generation of HockeyApp, which is called Mobile Center which is currently in Preview. You can find out more about that here: https://www.hockeyapp.net/blog/2016/11/16/mobile-center-next-generation-hockeyapp.html

Best, Andreas