search

bitstadium / HockeySDK-iOS

HockeyApp was retired and the SDKs are deprecated. Please use App Center instead.
https://github.com/microsoft/appcenter-sdk-apple
Other
597 stars 268 forks source link

Don't build the test target during the "Run" action of the framework. #394

Closed wiedem closed 7 years ago

wiedem commented 7 years ago

Not building the test target during the "Run" action of the framework gives us the possibility to easily build the framework via Carthage with any available configuration.

You currently get build errors if you try to build with the "ReleaseCrashOnly" configuration due to missing classes in the test target for this config.

After this change you for example can simply use the following command to build the framework for the "crash only" configuration: carthage build --configuration ReleaseCrashOnly

See also: https://github.com/bitstadium/HockeySDK-iOS/issues/372

msftclas commented 7 years ago

Hi @wiedem, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

ElektrojungeAtWork commented 7 years ago

Hey @wiedem,

This will be part of the next release. Thank you for this, you are awesome!

🖖

Benny

wiedem commented 7 years ago

Thank you for this, you are awesome!

You're welcome and thank you!

LLP 🖖