search

bitstadium / HockeySDK-iOS

HockeyApp was retired and the SDKs are deprecated. Please use App Center instead.
https://github.com/microsoft/appcenter-sdk-apple
Other
597 stars 268 forks source link

Remove LIBCXXABI_NORETURN for now #421

Closed pietbrauer closed 7 years ago

pietbrauer commented 7 years ago

This fixes compiling with Xcode 9. I suspect this to be the wrong solution to the problem though but I couldn't figure out how to do it otherwise. I am happy to adjust the PullRequest.

msftclas commented 7 years ago

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request. Thanks, Microsoft Pull Request Bot

lumaxis commented 7 years ago

Thanks @pietbrauer! I think the fix is actually fine since the compiler should be able to infer the "noreturn" part anyway. I'll do some testing and merge soon 🚀

ashfurrow commented 7 years ago

Getting this too, thanks Piet!