bitstadium / HockeySDK-iOS

HockeyApp was retired and the SDKs are deprecated. Please use App Center instead.
https://github.com/microsoft/appcenter-sdk-apple
Other
597 stars 268 forks source link

Disable code coverage #467

Closed cglarsen closed 7 years ago

cglarsen commented 7 years ago

Code coverage has to be disabled for Carthage to work with Xcode 9. Check https://github.com/Carthage/Carthage/issues/2056 and https://github.com/Carthage/Carthage/pull/2057.

On your repo two files need to be changed (sorry for not doing this in a PR)

Change codeCoverageEnabled = "YES"> to codeCoverageEnabled = "NO">

ElektrojungeAtWork commented 7 years ago

Thx @cglarsen for alerting us to this.

I can't give you an exact ETA for the release of 5.0.1. Thx for bearing with us.

cglarsen commented 7 years ago

Carthage fixed it on their side in release 0.26. Im closing this one. Thanks for the response. See https://github.com/Carthage/Carthage/releases/tag/0.26.0

ElektrojungeAtWork commented 7 years ago

@cglarsen thx for notifying me!!!