bitstadium / HockeySDK-iOS

HockeyApp was retired and the SDKs are deprecated. Please use App Center instead.
https://github.com/microsoft/appcenter-sdk-apple
Other
597 stars 268 forks source link

Xcode says: Update to recommended settings #490

Closed phoney closed 4 years ago

phoney commented 6 years ago

I'm using Xcode 9.2 (9C40b) and Hockey SDK 5.1.0 and cocoaPods 1.3.1.

Whenever I pod update Xcode says:

Target 'HockeySDK-HockeySDKResources' - Adopt "Product Bundle Identifier" build setting Target 'HockeySDK-HockeySDKResources' will have its Info.plists's CFBundleIdentifier key set to "$(PRODUCT_BUNDLE_IDENTIFIER)", and the "PRODUCT_BUNDLE_IDENTIFIER" build setting will be set to "$(PRODUCT_BUNDLE_IDENTIFIER)".

I always "perform changes" but maybe you can fix the project so this doesn't happen.

screen shot 2017-12-13 at 10 28 50 am

ElektrojungeAtWork commented 6 years ago

Hey @phoney !

Thx for raising this issue. We'll include this in ~5.1.1~ 5.1.2 – unfortunately (because of the approaching holidays, etc.) – I can't give you an ETA when this ships.

Thank you for understanding and for using HockeyApp in the first place!

Best, Benjamin

ElektrojungeAtWork commented 6 years ago

Hey @phoney,

this is actually a know issue with cocoapods itself https://github.com/CocoaPods/CocoaPods/issues/7316.

Let's hope they can fix it for 1.4.0.

ElektrojungeAtWork commented 6 years ago

Still around for cocoapods 1.4.0. Let's leave it open!

emartinson commented 6 years ago

Hi! Any news here?

ElektrojungeAtWork commented 6 years ago

Hey @emartinson,

looks like this is an ongoing issue with Xcode versions and Cocoapods (see https://github.com/CocoaPods/CocoaPods/issues/7206). We are planning an SDK release around the time of the public iOS 12 release and do some extended testing with the latest Cocoapods version. We'll update this issue accordingly.

nickhingston commented 6 years ago

Related to this, Xcode 10 also introduces a number of compiler warnings:

screenshot 2018-10-10 at 14 26 59

screenshot 2018-10-10 at 14 28 54

ElektrojungeAtWork commented 6 years ago

@nickhingston This doesn't look like you are integrating the HockeySDK with Cocoapods, how are you using the HockeySDK and which version?

ElektrojungeAtWork commented 6 years ago

I'm leaving this bug open because it mentions the messaging unqualified id warnings. There's a PR for fixing that #534.

FYI: I can't provide an ETA for the next SDK release.

ElektrojungeAtWork commented 6 years ago

I renamed the issue to reflect better what it is about.

nickhingston commented 6 years ago

great, thanks! in answer to your question, no not using cocoapods, just pulling as a subproject

ElektrojungeAtWork commented 6 years ago

That's what I thought. Sorry about the warnings, we'll triage this as a bug accordingly!

ElektrojungeAtWork commented 6 years ago

Warnings when integrating have been fixed. Unfortunately, I cannot provide an ETA when the next version will be released.

mickyzinho commented 5 years ago

Is this still not fixed?

elamalani commented 5 years ago

@mickyzinho There is no ETA on releasing HockeySDK with this fix. Our team is working on App Center as the next generation product for HockeyApp and I'd recommend to please look at App Center iOS SDK.

phoney commented 5 years ago

It's over a year. I think we know the answer is never. In fact I have moved to appcenter, although it has a ton of problems.

annakocheshkova commented 5 years ago

@phoney do not hesitate to open new issues. We'll be glad to help you and fix them! You can also start a conversation with us on App Center website using blue chat bubble in the bottom right.

elamalani commented 5 years ago

@phoney We are here to make the migration experience very smooth for HockeyApp customers, so please let us know any issues you are facing in App Center. As @annakocheshkova mentioned, you can click on the blue icon on the lower right of the App Center portal and start a conversation with us.