Make it possible to change current logging handler

bitstadium / HockeySDK-iOS

HockeyApp was retired and the SDKs are deprecated. Please use App Center instead.

https://github.com/microsoft/appcenter-sdk-apple

Other

597 stars 268 forks source link

Make it possible to change current logging handler #516

Closed piotrwach closed 6 years ago

piotrwach commented 6 years ago

It should be possible to change logging handler used inside HockeySDK. For example application that I am working on uses its own logging system, and we want all logs to use it, including 3rd party libraries.

msftclas commented 6 years ago

All CLA requirements met.

piotrwach commented 6 years ago

I don't know why one of the checks is failing, as I don't have permissions to view bitrise.

ElektrojungeAtWork commented 6 years ago

Hi @piotrwach, The HockeyLogger is not designed to be replaced by another logger. It's purpose is to allow for an API to adjust the amount of logs that the SDK emmits. Maybe I'm missing something in your PR, but how does making our header file public solve your issue?

piotrwach commented 6 years ago

@TroubleMakerBen our app requires all logs to be stored encrypted on the device. By making BITHockeyLogger.h header public, we can change currentLogHandler to use our internal logging system.

ElektrojungeAtWork commented 6 years ago

Thx for the explanation @piotrwach.