if available, give info-collecting textFields a content type

bitstadium / HockeySDK-iOS

HockeyApp was retired and the SDKs are deprecated. Please use App Center instead.

https://github.com/microsoft/appcenter-sdk-apple

Other

597 stars 268 forks source link

if available, give info-collecting textFields a content type #541

Closed diederich closed 5 years ago

diederich commented 5 years ago

The idea is to enable 'one-tap' filling of those textfields. I haven't actually tested this, as I don't think I have HockeySDK included in source-form anywhere right now, and the demo app doesn't seem to show the feedback UI. Do you have a Demo app that does?

diederich commented 5 years ago

This seems to work, although it could use some "massaging". E.g. update the "Save" indicator state after a paste of the email / name. I also saw that other parts in the file have __IPHONE_OS_VERSION_MAX_ALLOWED guards. Is building against < iOS 10 SDK still supported?

ElektrojungeAtWork commented 5 years ago

Hey Peter von Frosta, ;)

yes, we support iOS 9 and up.... we'll be in touch about the PR.

As always, thanks for the contribution =)

diederich commented 5 years ago

Hey @elektrojunge - hope things are good in Seattle! 👋 🤗

I'll add the __IPHONE_OS_VERSION_MAX_ALLOWED for compiling against an < iOS 10 SDK

diederich commented 5 years ago

🎁 😄