bitsy-ai / printnanny-os

Image repository, change logs, and issue tracking for PrintNanny OS
GNU Affero General Public License v3.0
23 stars 2 forks source link

Saving camera settings results in NatsError: TIMEOUT #266

Closed leigh-johnson closed 1 year ago

leigh-johnson commented 1 year ago

Describe the bug

Saving camera settings using the form results in NatsError: TIMEOUT

leigh-johnson commented 1 year ago

Looks like we're not deserializing caps correctly:

Feb 15 21:29:05 travelpi printnanny-edge-nats[682]: [2023-02-15T22:29:05Z ERROR printnanny_settings::cam] Failed to parse i32 from caps width=Err(ValueGetError { name: "width", error: ValueTypeMismatchError { actual: GstIntRange, requested: gint } }) with error=GetError: Structure field with name width not retrieved
29:05 travelpi printnanny-edge-nats[682]: [2023-02-15T22:29:05Z ERROR printnanny_settings::cam] Failed to get colorimetry caps, using default: bt701 error=GetError: Structure field with name colorimetry not found
Feb 15 21:29:05 travelpi printnanny-edge-nats[682]: [2023-02-15T22:29:05Z ERROR printnanny_settings::cam] Failed to parse i32 from caps height=Err(ValueGetError { name: "height", error: ValueTypeMismatchError { actual: GstIntRange, requested: gint } }) with error=GetError: Structure field with name height not retrieved
Feb 15 21:29:05 travelpi printnanny-edge-nats[682]: [2023-02-15T22:29:05Z ERROR printnanny_settings::cam] Failed to parse i32 from caps width=Err(ValueGetError { name: "width", error: ValueTypeMismatchError { actual: GstIntRange, requested: gint } }) with error=GetError: Structure field with name width not retrieved
Feb 15 21:29:07 travelpi printnanny-edge-nats[682]: [2023-02-15T22:29:07Z ERROR printnanny_nats::subscriber] Error deserializing NATS message: missing field `framerate_d` at line 1 column 210
leigh-johnson commented 1 year ago

🎉 Verified this is fixed in the latest build.

Screenshot 2023-02-16 at 12 24 16 AM
leigh-johnson commented 1 year ago

I found a regression for this issue in v0.6.5, which I've patched in v0.6.6.

The regression occurred if any of the checkboxes were un-ticked and then attempted to save the form. https://github.com/bitsy-ai/printnanny-os-dash/pull/158

leigh-johnson commented 1 year ago

👍 Confirming this regression is fixed in the latest v0.6.6 nightly