search

bittner / lego-mindstorms-ev3-comparison

LEGO Mindstorms EV3 Comparison
GNU General Public License v3.0
51 stars 12 forks source link

EV3 comparison spreadsheet bug #11

Open hreyhani opened 6 years ago

hreyhani commented 6 years ago

Hi,

Column #I in the spreadsheet sometimes showing excessive number of pieces to buy.

Here are a few examples:

Row #5: Home set has 0 pieces, Edu has 4 pieces & Exp has 5 pieces. Upgrade after Home+Exp should show 0 pieces to purchase but Column #H says Must Buy! and Column #I says 4 pieces.

Row #20: Home set has 0 pieces, Edu has 4 pieces & Exp has 2 pieces. Upgrade after Home+Exp should show 2 pieces to purchase but Column #H says Must Buy! and Column #I says 4 pieces.

Row #208: Home set has 0 pieces, Edu has 54 pieces & Exp has 5 pieces. Upgrade after Home+Exp should show 49 pieces to purchase but Column #H says Must Buy! and Column #I says 54 pieces.

The existing spreadsheet has Column #I=(Edu+Exp)-(Home+Exp) which is simply #I=Edu–Home.

This generates the difference between Home & Education sets without taking into account the extra pieces from the Expansion set.

Suggest modify Column #I’=IF((Home+Exp)>=Edu,"0",(Edu-(Home+Exp))) or something along these lines.

Btw, numbers in Column #L are correct.

Regards,

H

bittner commented 6 years ago

Can anyone else confirm these findings?

hreyhani commented 6 years ago

Just a recap, the existing spreadsheet shows a total of 303 pieces to be bought for upgrading Home+Exp to Edu whereas if the spreadsheet is fixed (as described above) the total drops to 169 pieces.

hreyhani commented 6 years ago

Anyone else interested in this?

bittner commented 6 years ago

For me this is not about whether other people are interested in the change. I need more people to confirm the issue, because I can't reliably verify it. There were some reasons why I made it like this in the past. And I don't remember.

The existing spreadsheet has Column #I=(Edu+Exp)-(Home+Exp) which is simply #I=Edu–Home.

This is technically true. Why I did it like this is simply to make the calculation, the algorithm more obvious. It's the sum of Edu+Exp minus Home+Exp. The result stays the same, doesn't it?

hreyhani commented 6 years ago

Ok, if understand it correctly Columns #H & #I are "supposed" to show (Home+Exp) - Edu, i.e. the upgrade from (Home+Exp) to Edu. But Column #I shows Edu-Home, i.e. the difference between Edu and Home sets ignoring the extra pieces from the Exp set. The result is a much higher number of missing pices (303) whereas if Exp pieces are taken into account the number of missing pieces get reduced to 169. To answer your question, result is not the same. Almost half the number of missing pieces. Is there some way of attaching the modified spreadsheet to this comment?

bittner commented 6 years ago

Is there some way of attaching the modified spreadsheet to this comment?

Please read up on GitHub pull requests (PRs). It's not as difficult as it sounds before you do it the first time.

The idea is: You change the Lego-Mindstorms-Editions-Comparison spread sheet directly. But on your own copy. With a PR you ask me (in this specific case) to take over your version of the file in my repository.

bittner commented 6 years ago

i.e. the difference between Edu and Home sets ignoring the extra pieces from the Exp set.

You may be right, but I'm not totally sure yet.

hreyhani commented 6 years ago

I've tried a few times to generate a PR and edit the spread sheet directly as per your instructions. Unsuccessful. Very sorry! I can send you updated spreadsheet via email and you generate the PR or simply verify my proposal how to improve the spreadsheet. It will save people extra pieces that they don't need.

bittner commented 6 years ago

I've tried a few times to generate a PR and edit the spread sheet directly as per your instructions.

It doesn't look like that: If you had tried to edit any file in this repository then GitHub automatically creates a fork under your personal account. However, there is none yet. Please, try again.

hreyhani commented 6 years ago

I just tried again without much luck... to be honest I don't understand the whole fork idea... i'm a hardware person with limited familiarity of software concepts... sorry!

hreyhani commented 6 years ago

I suggest we close this issue...

bittner commented 6 years ago

You shouldn't be frustrated. This is the usual learning curve. If you feel it's worth contributing to open source then walk the path.

In any case, this discussion alone is already worth something for people that find the same issue and look for an answer.

hreyhani commented 6 years ago

I was hoping by now we would have updated the spreadsheet showing the correct number of missing pieces for all the people interested in upgrading from one set to another... it is a very simple modification to the spreadsheet...

bittner commented 6 years ago

I was hoping you would simply

  1. download and install LibreOffice,
  2. download and edit the document,
  3. upload it back again and allow examination of the changes (by help of a PR).

This is how collaboration on open source projects works. Nobody is trying to make it deliberately difficult for you. Thank you for your understanding.

hreyhani commented 6 years ago

I've converted the .ods file to .xls using http://www.convertfiles.com/convert/document/ODS-to-XLS.html I've implemented the mods that improve the spreadsheet and reduce the number of missing pieces I'm stuck how to upload the new .xls file using PR... it doesn't work for me... sorry!