bittner / lego-mindstorms-ev3-comparison

LEGO Mindstorms EV3 Comparison
GNU General Public License v3.0
50 stars 12 forks source link

python script update for order #7

Closed bonidier closed 6 years ago

bonidier commented 6 years ago

Hi @bittner,

Thanks for your work !

Your Python script is very useful !

I think Lego has changed their website since your last script commit : the order URL in your script is now only to notify Lego about missing part of a product already buy.

some other problems :

So I've made a lot of change, updated requirements.txt about Selenium version.

I've also added a note about required browser's drivers in the README file.

Here is a test of this new script with Selenium/browser compare :

(only tested with Linux)

selenium 2.48.0

selenium 3.5.0

Regards

bonidier commented 6 years ago

Hi @bittner , I've fixed all your requests and more

flake8 report no error, except some "E501 line too long" due to printed strings I've done my best to reduce the number of E501 in order() function

tested with :

flake8 --ignore=E501 lego-mindstorms-pieces.py

Regards !

bittner commented 6 years ago

Thanks a lot for your contribution, @bonidier! Merci beaucoup !