search

bittorrent / libutp

uTorrent Transport Protocol library
http://github.com/bittorrent/libutp
MIT License
1.09k stars 262 forks source link

Improved Makefiles #44

Closed ssuominengentoo closed 11 years ago

ssuominengentoo commented 11 years ago

shared library, grab environment AR, CXX, *FLAGS, ..., all for packaging purposes so I can make the transmission p2p client use the system copy of libutp

would help a much if this was committed. grab the patch from here:

http://dev.gentoo.org/~ssuominen/libutp-Makefile.patch

ghazel commented 11 years ago

Ugh, I loathe Makefiles.

Could you submit this as a Github pull request?

ghazel commented 11 years ago

Oh, actually, what do you mean "system libtup"? libtup specifically says that is a bad idea. If a package manager has built libutp into a package they are asking for problems.

ssuominengentoo commented 11 years ago

Asking for problems? I don't have a problem diffing internal copy of libutp within transmission source tree to the libutp tree from here and adjusting the system package accordingly.

I'll try to make push req. today

ghazel commented 11 years ago

libutp is not considered stable enough to be included as a package in any package manager. It is designed to be compiled as part of your application.

ssuominengentoo commented 11 years ago

What made me want to package libutp separately is this bug:

http://trac.transmissionbt.com/ticket/5002

So instead of updating the security bug in multiple packages embedding libutp, I'd prefer to just patch libutp and automatically solve the others through it What a mess :/

ghazel commented 11 years ago

That patch hasn't been applied to libutp yet. It's not a good idea to go patching all the apps with it, unless the developers test is specifically.

When libutp applies it, developers should test their app with the latest version of libutp.

ssuominengentoo commented 11 years ago

OK then, I've removed the separately packaged libutp from Gentoo's CVS repository The patch doesn't really make any difference anymore, and I suppose proper autotools or cmake patch would be preferred anyways, so I'll just close this Thanks for clarification (it's what I was afraid of)

ghazel commented 11 years ago

Most preferred would be a setsockopt to allow applications to use the LEDBAT congestion controller with TCP instead of an application-level UDP transport to begin with ;)