bittremieux / falcon

Large-scale tandem mass spectrum clustering using fast nearest neighbor searching.
BSD 3-Clause "New" or "Revised" License
24 stars 7 forks source link

Weird numba caching issue #20

Open tycheyoung opened 2 years ago

tycheyoung commented 2 years ago

Due to the incorrect fraction part, the resulting dim can have an error (+1/-1 difference).

bittremieux commented 2 years ago

Could you elaborate a bit? When exactly does the issue occur and is it related to Numba or just a general issue?

tycheyoung commented 2 years ago

If we set min_mz = 101.00, max_mz = 1500.00, bin_size=0.05, the dimension needs to be 27981. When we enable numba caching, the fraction part of bin_size changes (in my system, it changes to 0.05000000074505806), resulting in 27982 dimension.