bitvavo / go-bitvavo-api

Go wrapper for Bitvavo API
ISC License
2 stars 2 forks source link

Unsubscribing from Subscriptions #5

Open dpsarrou opened 3 years ago

dpsarrou commented 3 years ago

Hi folks,

Thanks for building this sdk. I've noticed that the client does not implement unsubscribe functionality for the Subscriptions. Do you have any ETA on when this is implemented? Looking at the source code if one subscribes to for example the ticker for multiple markets, the memory will never be released if you don't need the events from some of the markets.

Even worse, if you later decide to read only from the ticker channels you are interested in, the operation blocks as the non-interesting channels have reached full capacity and there are no consumers..