Missing unsubscribe actions for websocket connections

bitvavo / node-bitvavo-api

Node wrapper for the Bitvavo API

ISC License

19 stars 15 forks source link

Missing unsubscribe actions for websocket connections #7

Closed quixot1c closed 3 years ago

quixot1c commented 3 years ago

When inspecting what the Bitvavo client does on Chrome I saw that it fires ubsubscribe actions in certain instances. However, these actions are missing from node-bitvavo-api.

joeri-vv commented 3 years ago

You are correct, we might implement this feature later. For now you can extend the SDK yourself by copying the subscribe message from the appropriate functions and replacing the 'subscribe' action with 'unsubscribe'.

the-serious-programmer commented 2 years ago

https://www.npmjs.com/package/bitvavo-fork/v/1.2.1 - a quick solution is published here

ca42rico commented 10 months ago

Fixed in PR 23 Thanks to @the-serious-programmer