search

bitvavo / php-bitvavo-api

PHP SDK IS DEPRECATED! PHP wrapper for the Bitvavo API
ISC License
15 stars 13 forks source link

Required parameters cannot follow optional parameters #11

Closed bvandevliet closed 2 years ago

bvandevliet commented 2 years ago

This PR solves the below PHP warnings:

PHP Deprecated: Required parameter $publicCommandArray follows optional parameter $bitvavo in ../vendor/bitvavo/php-bitvavo-api/bitvavo.php on line 364 PHP Deprecated: Required parameter $privateCommandArray follows optional parameter $bitvavo in ../vendor/bitvavo/php-bitvavo-api/bitvavo.php on line 364 PHP Deprecated: Required parameter $oldSocket follows optional parameter $bitvavo in ../vendor/bitvavo/php-bitvavo-api/bitvavo.php on line 364

EDIT:

This is already suggested in another PR commit:

https://github.com/bitvavo/php-bitvavo-api/commit/a75ad728c90eebef79f9d310958e1dbd86e981da