bitvavo / python-bitvavo-api

Python wrapper for the Bitvavo API
https://pypi.org/project/python-bitvavo-api/
ISC License
38 stars 25 forks source link

callback any websocket error (fixed branch) #14

Closed rroumenov closed 3 years ago

rroumenov commented 3 years ago

If any error in Websocket, on_error is called in order to use callbacks['error'] (if any). This would allow users managing and logging any error

joeri-vv commented 3 years ago

The only error which can not be handled by the user is the one specifying that he forgot to set his keys. I do not think it makes sense for the user to handle this is another manner than either setting his keys, or not requesting private functions without setting keys. Errors returned either over the websocket or originating from the websocket itself are both sent to the errorCallback, if it has been set.