search

bitvijays / AirPollutionDataPlatform

Platform for air pollution
0 stars 2 forks source link

Get pollution data / From location / Air Pollution Data - Link "Open In Window" Consistency #11

Closed kwmc-lucas closed 3 years ago

kwmc-lucas commented 4 years ago

The 'About' link at the bottom of 'What it means' opens in a new window. Similar issue to #5

anshulgaikwad01 commented 4 years ago

I'm not sure if I get it. Should its normal behavior be to open in the new window, or is it a discrepancy?

kwmc-lucas commented 4 years ago

What I'd recommend as the default behaviour is different depending on whether they are internal or external links.

Internal links should all open in the same window. External links should all open in a new window.

Currently there is a mix of the two without consistency.

bitvijays commented 3 years ago

@anshulgaikwad01 This could be fixed very easily by changing the line https://github.com/Kevjolly/AirPollutionDataPlatform/blob/master/website/public/views/datafromlocation.html#L231