bitvijays
commented
3 years ago @anshulgaikwad01
Info Tab
Currently, it seems that currently the data is populated directly from the backend (like whatever comes). Maybe we want to remove the Record ID, Dataset ID, Site ID, Reading Count. So, I assuming, the code which requires changing would be in function https://github.com/bitvijays/AirPollutionDataPlatform/blob/master/website/public/js/map.js#L104 .
It seems currently, when the property is one of the above Record ID, Dataset ID, Site ID, it adds the records. So, maybe what we require is when the above fields are found, don't add them.
Important: Debug the working of function buildMarkPopRecord , learn and see the solution is correct.
Last record : Change Last record to Recent reading , Just search map.js file with Last record, you would find out where to make the change.
More Data Let's leave this as is as of now. Will see later.
I love this bit, one of my favourite parts, but again it’s not very human readable and should be rethought.
Info tab -
This should just be identifying information for the sensor, therefore it doesn't need dates etc. Could be improved human-readability-wise.
Last decord tab -
The title of this tab should maybe be 'Most Recent Reading' or something along those lines. and that tab is where the timestamp (or a readable one) should be - perhaps even calculate how long ago such as “20 hours ago”?
For most of the readings... could the decimal place be a bit closer? I don't think we need it to 10 or whatever haha.
More data tab -
It'd probably be best to make this a link to the More data page, rather than having it as a tab that you then have to click on to go to more data. Perhaps include the icon in the tab selection so people know it's going to open a new tab / different page?