search

bitvijays / AirPollutionDataPlatform

Platform for air pollution
0 stars 2 forks source link

Decimal issue on QualityMap #30

Closed bitvijays closed 3 years ago

bitvijays commented 3 years ago

@anshulgaikwad01 Thank for the good work. Can you ensure lines https://github.com/bitvijays/AirPollutionDataPlatform/pull/30/files#diff-22b192b9f2aabd6d42918f4d64ebbe1d07062ce89d79388441dcee4c8459c043L803 are good and in sync?

Also, may instead of using toFixed(2) two times. Maybe we should have it like the original author did here https://github.com/bitvijays/AirPollutionDataPlatform/blob/master/website/public/js/map.js#L602

i.e create a variable valueToDisplay and check for NaN and then use that ? for consistency.

bitvijays commented 3 years ago

Thank You @anshulgaikwad01 for your efforts! Merged