bitwalker / distillery-aws-example

An example application to go with the AWS guide in the Distillery documentation
Apache License 2.0
52 stars 73 forks source link

Fix generate_secret punctuation bug and typo for stack_events function #3

Closed ntilwalli closed 6 years ago

ntilwalli commented 6 years ago

Firstly, thank you for this wonderful repository! I'm learning so much about AWS and Elixir deployments from it!

I've fixed two bugs: 1) Typo referring to a call to stack_events, was originally typed stack-events 2) Updated the generate_secret function to filter out disallowed password characters based on seeing this error message during deployment.

The  parameter MasterUserPassword is not a valid password. Only printable  ASCII characters besides '/', '@', '"', ' ' may be used. (Service:  AmazonRDS; Status Code: 400; Error Code: InvalidParameterValue; Request  ID: ce4062f4-4f7e-43b9-bb73-ff3834eb9c07)
bitwalker commented 6 years ago

Thanks!