PIDFILE broken in 2.0.9

lasseebert commented 6 years ago

Steps to reproduce

Use distillery 2.0.9
Build a release
Start release with PIDFILE=/path/to/pidfile _build/dev/rel/myapp/bin/myapp console

The command then just hangs an nothing is outputted.

Verbose Logs

Even with --verbose nothing is outputted

Description of issue

Expected that the app would start a console
Version 2.0.9 is affected. This works in 2.0.8
Run on Ubuntu 18.04

I have tried looking in the commit history, but I can't find where this changed.

My config is (I think only difference from default config is that I don't include ERTS):

# Import all plugins from `rel/plugins`
# They can then be used by adding `plugin MyPlugin` to
# either an environment, or release definition, where
# `MyPlugin` is the name of the plugin module.
~w(rel plugins *.exs)
|> Path.join()
|> Path.wildcard()
|> Enum.map(&Code.eval_file(&1))

use Mix.Releases.Config,
    # This sets the default release built by `mix release`
    default_release: :default,
    # This sets the default environment used by `mix release`
    default_environment: Mix.env()

# For a full list of config options for both releases
# and environments, visit https://hexdocs.pm/distillery/config/distillery.html

# You may define one or more environments in this file,
# an environment's settings will override those of a release
# when building in that environment, this combination of release
# and environment configuration is called a profile

environment :dev do
  set cookie: :"SECRET"
end

environment :prod do
  set cookie: :"SECRET"
end

# You may define one or more releases in this file.
# If you have not set a default release, or selected one
# when running `mix release`, the first release in the file
# will be used by default

release :balrog do
  set version: current_version(:balrog)
  set include_erts: false
  set include_src: false
end

lasseebert commented 6 years ago

I forgot to mention that if the 2.0.9 release is run without PIDFILE it works as expected (but then I don't have a pidfile of course).

OvermindDL1 commented 6 years ago

As a work-around if needed to use with 2.0.9 my PidFile library should suffice until this is fixed.

bitwalker commented 6 years ago

Can you try master? There are some fixes there that have not yet been released

lasseebert commented 6 years ago

@bitwalker: Same issue in master

bitwalker commented 6 years ago

Thanks @lasseebert, I'll take a look here shortly!

bitwalker commented 6 years ago

This should be fixed in master/2.0.10

lasseebert commented 6 years ago

@bitwalker: Thanks :) Can confirm that my issue is gone in master :tada:

bitwalker commented 6 years ago

Awesome :) I'll be pushing 2.0.10 shortly

bitwalker / distillery