bitwalker / distillery

Simplify deployments in Elixir with OTP releases!
MIT License
2.96k stars 398 forks source link

Make vm.args explicit #555

Closed DianaOlympos closed 5 years ago

DianaOlympos commented 5 years ago

Summary of changes

To make the vm.args file more explicit to the user, we create a default vm.args that we put at the root of the rel folder through release.init. Additionaly we make rel/config.exs use it.

We also provide an update for OTP21+ for the args.

We keep the old vm.args for backward compatibility for project already using distillery.

There was a couple of formatting things added, i can get them out and open another PR if needed for them.

Checklist

Licensing/Copyright

By submitting this PR, you agree to the following statement, please read before submission!

I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for Distillery (the "Contribution"). My Contribution is licensed under the MIT License.

NOTE: If you submit a PR and remove the statement above, your PR will be rejected. For your PR to be considered, it must contain your agreement to license under the MIT license.

bitwalker commented 5 years ago

Thanks! I like that this is now explicit, rather than generated from thin air :)

DianaOlympos commented 5 years ago

Yeah that was the goal. Should make it easier for users to know where it come from and understand what they can do now :)