bitwalker / distillery

Simplify deployments in Elixir with OTP releases!
MIT License
2.96k stars 398 forks source link

Docs: Add a tip about where to put the migration runner module #557

Closed macbem closed 5 years ago

macbem commented 5 years ago

I've encountered the problem solved by this commit while I was learning Distillery through this tutorial - I think that it'd be nice to have the place for App.ReleaseTasks mentioned in the docs, especially for beginners.

Summary of changes

I'll review the commits, so I mostly want to understand the "why" rather than the "what"

Checklist

Licensing/Copyright

By submitting this PR, you agree to the following statement, please read before submission!

I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for Distillery (the "Contribution"). My Contribution is licensed under the MIT License.

NOTE: If you submit a PR and remove the statement above, your PR will be rejected. For your PR to be considered, it must contain your agreement to license under the MIT license.

macbem commented 5 years ago

It looks like there are some problems with AppVeyor builds, because tests are failing even though I didn't change any code or examples.

macbem commented 5 years ago

@bitwalker Hey, sorry for the late reply - I've changed my contribution as you requested. Do you need anything more for this PR to be accepted?

bitwalker commented 5 years ago

Thanks!