Closed niku closed 5 years ago
Hi, I just tried this change out in my own Makefile, I noticed some downsides when using this cleaner approach.
mix run -e '...'
starts the application, which will in my case connect to the database.The example in the docs is not necessarily totally flexible, but it is consistent with the example application it is used with; in general I prefer the faster option, and as you've found, it is quite easy to have the version be parsed however you like. While I appreciate the desire for a cleaner approach in the docs here, that particular piece is mostly a bonus feature for people to play with, and as pointed out by @philipgiuliani, there are some downsides.
I'm going to close this PR, but if the issue comes up again and there is some consensus around the best approach, I'm happy to make changes at that point. Thanks for the PR!
Summary of changes
It changes getting app information in a straightforward way. It makes a bit slower, but getting better readability.
Checklist
Licensing/Copyright
By submitting this PR, you agree to the following statement, please read before submission!
I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for Distillery (the "Contribution"). My Contribution is licensed under the MIT License.
NOTE: If you submit a PR and remove the statement above, your PR will be rejected. For your PR to be considered, it must contain your agreement to license under the MIT license.