bitwalker / distillery

Simplify deployments in Elixir with OTP releases!
MIT License
2.96k stars 398 forks source link

Add note for ecto 3 users to bump the pool_size #578

Closed LostKobrakai closed 5 years ago

LostKobrakai commented 5 years ago

Summary of changes

Ecto 3 requires a pool_size of 2. One for locking and one for running the migrations.

Checklist

Licensing/Copyright

By submitting this PR, you agree to the following statement, please read before submission!

I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for Distillery (the "Contribution"). My Contribution is licensed under the MIT License.

NOTE: If you submit a PR and remove the statement above, your PR will be rejected. For your PR to be considered, it must contain your agreement to license under the MIT license.

stefanluptak commented 5 years ago

Wouldn't it be better to use pool_size: 2 for all versions to prevent confusion?

LostKobrakai commented 5 years ago

Maybe. I didn't change it because by now ecto 3 is still rc and people might still wonder why it's using not just one connection.