bitwalker / distillery

Simplify deployments in Elixir with OTP releases!
MIT License
2.96k stars 397 forks source link

572 fix windows releases #615

Closed PaoloLaurenti closed 5 years ago

PaoloLaurenti commented 5 years ago

Summary of changes

This in an attempt to fix issue #572 . After a lot of trials and errors I figured out that the problem happened because of the presence of the erl.ini file inside the included erts folder. The erl.ini file contained some paths that were referring the erlang binaries of the building machine and (obviously) they didn't exist on the machine where the release was running. I tried to manually remove the erl.ini file and everything seemed fine. So, I added a step to remove the erl.ini file when creating a release including erts. Unfortunately I wasn't able to find a reference where was explained if the erl.ini file is somewhat mandatory or not (by my tests it seems not...)

Checklist

Licensing/Copyright

By submitting this PR, you agree to the following statement, please read before submission!

I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for Distillery (the "Contribution"). My Contribution is licensed under the MIT License.

NOTE: If you submit a PR and remove the statement above, your PR will be rejected. For your PR to be considered, it must contain your agreement to license under the MIT license.