search

bitwalker / distillery

Simplify deployments in Elixir with OTP releases!
MIT License
2.96k stars 397 forks source link

Fix #617 #618

Closed siegfried closed 5 years ago

siegfried commented 5 years ago

Summary of changes

Correct the regular expression used by grep.

According to grep manual of both OpenBSD and macOS:

grep is used for simple patterns and basic regular expressions (BREs); egrep can handle extended regular expressions (EREs).

"|" is an ordinary character of BREs, so ^\-\(sn\|n\)ame should not work for grep. However, it works in macOS, which lead to the issue I guess. Gonna need to be careful to the commands in macOS.

Checklist

Licensing/Copyright

By submitting this PR, you agree to the following statement, please read before submission!

I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for Distillery (the "Contribution"). My Contribution is licensed under the MIT License.

NOTE: If you submit a PR and remove the statement above, your PR will be rejected. For your PR to be considered, it must contain your agreement to license under the MIT license.

bitwalker commented 5 years ago

Thanks! There are multiple platforms in play, but I don't typically test on BSD, which is probably why this got missed.