xxhenglyxx commented 5 years ago

Steps to reproduce

path to run bin/app_server/foreground

Verbose Logs

Paste the output of the release command you ran with the --verbose flag below in the summary tags (this helps keep the issue easy to navigate):

Description of issue

What are the expected results? -> App runs and output something like your app is running on :::port, and here is the error when running it

init terminating in do_boot ({,[{erlang,binary_to_integer,
,[]},{erl_eval,do_apply,6,[{_},{_}]},{erl_eval,expr,5,[{_},{_}]},{erl_eval,exprs,5,[{_},{_}]},{elixir,eval_forms,4,[{_},{_}]},{Elixir.Code,ev

Crash dump is being written to: erl_crash.dump...done
=INFO REPORT==== 20-May-2019::13:42:47.674549 ===
    application: mix
    exited: stopped
    type: temporary
argument error
    :erlang.binary_to_integer(10)
    (stdlib) erl_eval.erl:680: :erl_eval.do_apply/6
    (stdlib) erl_eval.erl:449: :erl_eval.expr/5
    (stdlib) erl_eval.erl:126: :erl_eval.exprs/5
    (elixir) src/elixir.erl:258: :elixir.eval_forms/4
    (elixir) lib/code.ex:232: Code.eval_string/3
    (mix) lib/mix/config.ex:220: Mix.Config.eval!/2
    (distillery) lib/mix/lib/releases/config/providers/elixir.ex:80: Mix.Releases.Config.Providers.Elixir.eval!/2

{"init terminating in do_boot",{#{'__exception__'=>true,'__struct__'=>'Elixir.ArgumentError',message=><<"argument error">>},[{erlang,binary_to_integer,"\n",[]},{erl_eval,do_apply,6,[{file,"erl_eval.erl"},{line,680}]},{erl_eval,expr,5,[{file,"erl_eval.erl"},{line,449}]},{erl_eval,exprs,5,[{file,"erl_eval.erl"},{line,126}]},{elixir,eval_forms,4,[{file,"src/elixir.erl"},{line,258}]},{'Elixir.Code',eval_string,3,[{file,"lib/code.ex"},{line,232}]},{'Elixir.Mix.Config','eval!',2,[{file,"lib/mix/config.ex"},{line,220}]},{'Elixir.Mix.Releases.Config.Providers.Elixir','eval!',2,[{file,"lib/mix/lib/releases/config/providers/elixir.ex"},{line,80}]}]}}
Unable to configure release!

What version of Distillery? -> 2.0.14
What OS, Erlang/Elixir versions are you seeing this issue on? -> OSX Mojave and alpine:3.9, elixir:1.8.2
If possible, also provide your rel/config.exs, as it is often my first troubleshooting question, and you'll save us both time :)
```
# rel/config.exs
~w(rel plugins *.exs)
|> Path.join()
|> Path.wildcard()
|> Enum.map(&Code.eval_file(&1))
```

use Mix.Releases.Config, default_release: :default, default_environment: Mix.env()

environment :dev do set dev_mode: true set includeerts: false set cookie: :"l5IbBfyF]$21)C)uk?K88<cQj(UpeFD(*9FSotIg!}&{S0HVE,q.te59Q}X%Z" end

environment :prod do set include_erts: true set includesrc: false set cookie: :"IP)x/}2r:c@uJpHBIKm4%=N|t3BAgyP^d2)wv0vw!mhNdES3k.Bl,i&Io<N/sXg" set vm_args: "rel/vm.args"

set config_providers: [ {Mix.Releases.Config.Providers.Elixir, ["${RELEASE_ROOT_DIR}/etc/runtime_config.exs"]} ]

set overlays: [ {:copy, "rel/runtime_config.exs", "etc/runtime_config.exs"} ] end

release :app_server do set version: current_version(:app_server) set applications: [ :runtime_tools ] end

rel/runtime_config.exs

use Mix.Config

db_pool = String.to_integer(System.get_env("DB_POOL") || 10) smtp_port = String.to_integer(System.get_env("SMTP_PORT") || 587) server_port = String.to_integer(System.get_env("SERVER_PORT") || 5000) redis_pool = String.to_integer(System.get_env("REDIS_POOL_SIZE") || 5)

config :app_server, AppServer.Mailer, server: System.get_env("SMTP_SERVER"), hostname: System.get_env("SMTP_HOST"), port: smtp_port, username: System.get_env("SMTP_USER"), password: System.get_env("SMTP_PASSWORD")

config :app_server, AppServer.Repo, username: System.get_env("DB_USER"), password: System.get_env("DB_PASSWORD"), database: System.get_env("DB_NAME"), hostname: System.get_env("DB_HOST"), pool_size: db_pool

config :app_server, AppServerWeb.Endpoint, secret_key_base: System.get_env("SECRET_KEY_BASE"), url: [host: System.get_env("SERVER_HOST"), port: server_port], http: [:inet6, port: server_port], pubsub: [ adapter: Phoenix.PubSub.Redis, node_name: System.get_env("REDIS_NODE"), host: System.get_env("REDIS_HOST"), name: AppServer.PubSub, pool_size: redis_pool ]

config :app_server, AppServer.Guardian, issuer: System.get_env("JWT_TOKEN_ISSUER"), secret_key: System.get_env("JWT_SECRET_KEY")

config :ex_aws, debug_requests: false, access_key_id: System.get_env("AWS_API_KEY"), secret_access_key: System.get_env("AWS_API_SECRET"), s3: [ scheme: "https://", host: System.get_env("AWS_BUCKET_NAME") <> ".s3.amazonaws.com", region: System.get_env("AWS_BUCKET_REGION") ]

config :app_server, :aws_bucket_name, System.get_env("AWS_BUCKET_NAME")

config :app_server, :smtp_user, System.get_env("SMTP_USER")

config :app_server, :redis_cache_host, System.get_env("REDIS_CACHE_HOST")

config :app_server, :cors_origin, System.get_env("CORS_ORIGIN")

config :app_server, :nexmo_api_key, System.get_env("NEXMO_API_KEY") config :app_server, :nexmo_api_secret, System.get_env("NEXMO_API_SECRET")


- Is there documentation that says one thing, but Distillery does
  another? If so, please link the doc here so it can be updated if
  it's a documentation issue, or so that the fix can be based around
  what's documented. -> I think no, the release works before but not now.
- If this is a runtime configuration issue, please also provide your config file 
  (with any sensitive information stripped of course). This is almost
  always necessary to understand why some configuration may not be working. -> Already provided along with `rel/config.exs`

The error are both the same inside docker and on my mac machine, they both release success but error when running it.

xxhenglyxx commented 5 years ago

Sorry for this silly issue lol, the problem was actually about the System.get_env("DB_POOL"), which my environment variable name was DB_POOL_SIZE=10, after changing it back to DB_POOL, it works as expected now.

redpublic commented 4 years ago

Sorry for this silly issue lol, the problem was actually about the System.get_env("DB_POOL"), which my environment variable name was DB_POOL_SIZE=10, after changing it back to DB_POOL, it works as expected now.

@xxhenglyxx How did you get the incorrect line in your runtime_config.exs? Sometimes it becomes quite a task as there is no runtime_config line number in stack_trace

bitwalker / distillery

released app crash on run #669

Steps to reproduce

Verbose Logs

Description of issue

rel/runtime_config.exs