Documentation fixes for Phoenix guide

moxley commented 4 years ago

Summary of changes

The application script failed because the project's parent directory had a space in it.
The PORT config didn't work because logical expressions can't be evaluated in config/prod.exs during boot time.

Checklist

[ ] New functions have typespecs, changed functions were updated
[ ] Same for documentation, including moduledocs
[ ] Tests were added or updated to cover changes
[ ] Commits were squashed into a single coherent commit

Licensing/Copyright

By submitting this PR, you agree to the following statement, please read before submission!

I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for Distillery (the "Contribution"). My Contribution is licensed under the MIT License.

NOTE: If you submit a PR and remove the statement above, your PR will be rejected. For your PR to be considered, it must contain your agreement to license under the MIT license.

bitwalker commented 4 years ago

If you can remove the fix to release_rc_exec.eex (that code was fixed in another PR), I'll get this merged :)

bitwalker commented 4 years ago

Actually, I ended up just making the change as part of another PR. Thanks for contributing though!

bitwalker / distillery