bitwalker / distillery

Simplify deployments in Elixir with OTP releases!
MIT License
2.96k stars 396 forks source link

Update "Deploying with Docker" docs for Elixir 1.12 #737

Open nclark opened 3 years ago

nclark commented 3 years ago

Summary of changes

I'm not necessarily suggesting this PR be merged, I'm curious to hear what others think about the solution. My app's docker image was heavily influenced by the "Deploying with Docker" distillery docs, and I ran into an issue when upgrading to Elixir 1.12. Namely using the elixir:1.12.1-alpine base image results in errors being thrown because libstdc++.so.6 is missing. Following along at https://github.com/erlef/docker-elixir/issues/20 I see this is because the new JIT feature in OTP 24 expects to dynamically link libc, but alpine uses musl instead. The solution there is to add libstdc++ back into the final container.

Checklist

Licensing/Copyright

By submitting this PR, you agree to the following statement, please read before submission!

I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for Distillery (the "Contribution"). My Contribution is licensed under the MIT License.

NOTE: If you submit a PR and remove the statement above, your PR will be rejected. For your PR to be considered, it must contain your agreement to license under the MIT license.