bitwalker / exrm

Automatically generate a release for your Elixir project!
MIT License
923 stars 110 forks source link

hmac undefined when starting a packaged release #71

Closed mweibel closed 10 years ago

mweibel commented 10 years ago

Commit to test here: https://github.com/mweibel/exrm-test/commit/26eff983d03165567587deceafd08d9452831e93 Branch: https://github.com/mweibel/exrm-test/tree/bug/crypto-hmac

When using hmac functions from erlang and using exrm to release an app it will fail to start or to use the code where the hmac functions are being used. I tried adding crypto to the list of applications but this doesn't help.

Thanks :)

bitwalker commented 10 years ago

I'm unable to find a reference for any module called hmac in the Erlang standard library. The only function I see for hmac is crypto:hmac/2 and crypto:hmac/3. Do you have a link for that module/function that I can look at for documentation?

mweibel commented 10 years ago

Thanks for the reply. Just figured out from where it comes (original code in question: https://github.com/wooga/fb_signed_request/blob/master/src/fb_signed_request.erl#L85), it's the erlsha2 module so it looks like fb_signed_request app should have the erlsha2 module in the list of applications (which it doesn't have: https://github.com/wooga/fb_signed_request/blob/master/src/fb_signed_request.app.src).

Sorry for the wrong issue, still a bit getting used to the whole ecosystem and how it works together ;)

bitwalker commented 10 years ago

Hey no worries, good to know about that module myself for future reference. Glad that ended up being the issue!