search

bitwalker / libgraph

A graph data structure library for Elixir projects
MIT License
524 stars 75 forks source link

Add conversion from dot to png #24

Open swerter opened 5 years ago

swerter commented 5 years ago

Add the function to_png, which compiles the dot file into a png file.

dunyakirkali commented 8 months ago

This looks quite handy. Any reason why the MR is still open?

mindok commented 6 months ago

@dunyakirkali - I'd imagine because it relies on an external command-line dependency (dot) which may or may not be installed. It would probably be better to have the function in the PR defined in your project rather than the library rather than have a library function fail due to a missing dependency that the library has no control over.

bitwalker commented 6 months ago

That's essentially the hang up. I think it is useful, and the PR is solid, but I'm hesitant to add a third party dependency, especially one needed for the test suite.

I think my preference would be to have a way to extend libgraph with capabilities like this in the form of third-party packages, as is done for many libraries. I just haven't decided how to handle that yet, and haven't had the time. I've left the PR open for those that wish to use it in their own projects by merging it into a fork, and until I can make a decision on how to move forward with it.

dunyakirkali commented 6 months ago

Makes sense