search

bitwalker / swarm

Easy clustering, registration, and distribution of worker processes for Erlang/Elixir
MIT License
1.21k stars 103 forks source link

Do not update tracker clock with registry entry clocks #116

Closed tschmittni closed 5 years ago

tschmittni commented 6 years ago

This is a follow up of https://github.com/bitwalker/swarm/pull/85

I forgot to change the handle_topology_change method which is as far as I can tell also the root cause for https://github.com/bitwalker/swarm/issues/106

tschmittni commented 6 years ago

I managed to reproduce https://github.com/bitwalker/swarm/issues/106 and this is happening because the clock gets forked on every anti-entropy sync. I removed the fork and added some more debug output when clock-forks are happening which should only be when a new node joins a cluster.

arjan commented 6 years ago

This is great! Do you think the situation you describe could be made reproducible in a testcase?

tschmittni commented 6 years ago

Added a test case

beardedeagle commented 6 years ago

This looks good so far, as I've been able to duplicate #106 myself I am going to pull this down and give it a spin.

picaoao commented 6 years ago

Tests are failing ... Any news on this ? This seems like a pretty critical and important fix !

tschmittni commented 5 years ago

Tests have been failing on the master branch before. Did this change cause any new failures?