search

bitwalker / swarm

Easy clustering, registration, and distribution of worker processes for Erlang/Elixir
MIT License
1.21k stars 103 forks source link

Compile Warning with version 3.3.1 on Elixir 1.8.0-otp-21.2.2 #123

Closed OvermindDL1 closed 5 years ago

OvermindDL1 commented 5 years ago 
warning: found quoted keyword "test" but the quotes are not required. Note that keywords are always atoms, even when quoted. Similar to atoms, keywords made exclusively of Unicode letters, numbers, underscore, and @ do not require quotes
  /home/<user>/<project>/deps/swarm/mix.exs:63

==> swarm
Compiling 1 file (.erl)
Compiling 10 files (.ex)
warning: found quoted atom "nonode@nohost" but the quotes are not required. Atoms made exclusively of Unicode letters, numbers, underscore, and @ do not require quotes
  lib/swarm/tracker/tracker.ex:45

warning: variable "nclock" is unused (if the variable is not meant to be used, prefix it with an underscore)
  lib/swarm/tracker/tracker.ex:854

warning: variable "nclock" is unused (if the variable is not meant to be used, prefix it with an underscore)
  lib/swarm/tracker/tracker.ex:863

Generated swarm app

When depender project is compiling with warnings as errors it fails to build.

arjan commented 5 years ago

I think all of these warnings have been fixed. @bitwalker a while back we talked about baking a new release, could you do it?

@OvermindDL1 in the meantime you might consider running from master. There also have been quite a few fixes related to the tracker management.

bitwalker commented 5 years ago

Will do @arjan

beardedeagle commented 5 years ago

They are fixed . I've been on master for a bit and these don't appear @OvermindDL1. @bitwalker, @arjan is correct in asking for a new release.

OvermindDL1 commented 5 years ago

@beardedeagle All good, I'm just updating my work CI (which is forced with warnings as errors globally) and my work doesn't like using git dependencies, either hex.pm straight or full fork, and forking for this just seems bad, so I'm waiting for the release. :-)

beardedeagle commented 5 years ago

Gotcha, fair dinkum

bitwalker commented 5 years ago

3.4.0 is up on Hex :)

OvermindDL1 commented 5 years ago

Woot! Compiles clean! Thanks much!!