Fix test cases - Githubissues

arjan commented 6 years ago

This has become quite a large commit. I started from #74 to see if I could fix all the test cases. So basically this commit introduces a few things:

mix format the codebase (was not really needed, but makes it easier for contributions in the future)
Fix various existing test cases by sometimes adding longer timeouts, restarting the :swarm application inbetween tests, clearing the registry, adjusting the node blacklist, etc.
Some test cases still randomly failed (most notably quorum_test.exs; after tracing it down to the usage of the Clock CRDT, I merged #85 into this branch, which fixed the remaining tests.
Clean up the test output; added SWARM_DEBUG=true environment variable to see all verbose messages (documented in the README).
Remove use of --seed 0 argument, to ensure tests can be executed independently of each other.

I can imagine this is a big PR to review but I did not touch any logic code except for merging in the #85 branch. (well, except e793c7889271f8aa77d5d3651b5bb538e504d98d, but those changes were overwritten by the #85 merge anyway)

Eventually, a lot of (clustering) boilerplate could be lifted out of the test code but I noticed you're already working on that ;-)

beardedeagle commented 6 years ago

Any movement on this @bitwalker?

bitwalker commented 6 years ago

Looks like this conflicts with #85 - is this intended to replace that PR? I can undo the merge and merge this instead if it supercedes it - otherwise please rebase :)

arjan commented 6 years ago

This is indeed intended to replace #85. I see that it has conflicts now, I'll fix those next week, I'm on holiday currently.

arjan commented 6 years ago

Seems most conflicts are related to formatting.

bitwalker commented 6 years ago

@arjan I did the merge for you, can you verify when you get a chance? I'm pretty sure it was all formatting related, but there were larger changes in one of the test files, and I chose to just favor the changes in this PR rather than try to parse through what all of the changes were, since formatting was mixed in there.

Speaking of which, please don't make formatting changes as part of PRs like this, I'm totally fine with those being made in their own PR, or alongside small changes, because they can basically be merged straight away, but it makes large changes harder to review when mixed together, and in cases like this, can result in somewhat painful merges. No worries this time though :)

bitwalker commented 6 years ago

Thanks so much!

bitwalker / swarm

Fix test cases #94