search

bitwalker / timex_ecto

An adapter for using Timex DateTimes with Ecto
MIT License
162 stars 68 forks source link

Error when using latest Ecto rc-3 #51

Closed AndrewDryga closed 7 years ago

AndrewDryga commented 7 years ago

@bitwalker Application won't build with timex_ecto:

Duplicated modules: 
        'Elixir.Ecto.DataType.NaiveDateTime' specified in timex_ecto and ecto
        'Elixir.Ecto.DataType.DateTime' specified in timex_ecto and ecto
        'Elixir.Ecto.DataType.Date' specified in timex_ecto and ecto
Samorai commented 7 years ago

@bitwalker Hi! The problem because Ecto has added the same modules but just with dump function. https://github.com/elixir-ecto/ecto/blob/v2.1.0-rc.3/lib/ecto/data_type.ex#L55

I think we can rename your modules and add prefix Timex. I can do PR for this fix.

bitwalker commented 7 years ago

Fixed in master.