bitwalker / timex_ecto

An adapter for using Timex DateTimes with Ecto
MIT License
162 stars 68 forks source link

Missing last argument in first Ecto example #75

Closed maltoe closed 6 years ago

maltoe commented 6 years ago

Hi,

This just cost me 10 minutes or so :man_facepalming:. Especially because it doesn't error (guess autogenerate/0 is called), but instead just comes up with NULL in the timestamp columns.

Also, I think these sections are valid again? The DEPRECATED was removed before, so I guess the strikethrough is not intended.

Best, malte

bitwalker commented 6 years ago

Sorry about that :( - thanks for fixing the docs and sending a long a PR!

maltoe commented 6 years ago

Nah, I was being stupid, should have read the entire README first, and come to the Example section before trying it :-)

Glad to help